Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fixes terminology in Stack Monitoring:Kibana alerts #101696

Merged
merged 3 commits into from
Jun 10, 2021
Merged

[DOCS] Fixes terminology in Stack Monitoring:Kibana alerts #101696

merged 3 commits into from
Jun 10, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 9, 2021 •
edited
Loading

@lcawl lcawl marked this pull request as ready for review June 9, 2021 01:05
@lcawl lcawl requested a review from igoristic June 9, 2021 01:05
@igoristic igoristic mentioned this pull request Jun 9, 2021
Closed
@igoristic igoristic requested review from ravikesarwani and removed request for igoristic June 9, 2021 22:04
@lcawl
Copy link
Contributor Author

lcawl commented Jun 10, 2021

687be06 integrates screen shots and text from #101703

@ravikesarwani
Copy link
Contributor

@lcawl Are we good in making the "rules" terminology change in the doc without the SM UI changes (7.13.2)?
Ideally we target both the SM UI and doc changes in 7.14 so they are consistent.
cc: @jasonrhodes

@ravikesarwani
Copy link
Contributor

@lcawl & @jasonrhodes In the interest of time I will approve the pull request. These doc changes have so much goodness. I wasn't sure if it was okay to make the alerts to rules changes yet because the SM UI is still calling in alerts in all the places.
Considering all the other updates this addresses around user confusion and different SDH I will approve so it can get merged ASAP.

@lcawl
Copy link
Contributor Author

lcawl commented Jun 10, 2021

I wasn't sure if it was okay to make the alerts to rules changes yet because the SM UI is still calling in alerts in all the places.

There were two .tsx files that were updated in the other PR, which I didn't carry forward in this one. I'll do it now in a separate PR in case those are the additional changes you're seeking.

@lcawl lcawl merged commit 95604fd into elastic:master Jun 10, 2021
@lcawl lcawl deleted the kibana-alerts branch June 10, 2021 22:48
lcawl added a commit to lcawl/kibana that referenced this pull request Jun 10, 2021
@lcawl
[DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (elastic#1…
f2bbe99 
…01696)
@lcawl lcawl mentioned this pull request Jun 10, 2021
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request Jun 10, 2021
@lcawl
[DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (elastic#1…
c564641 
…01696)
@lcawl lcawl mentioned this pull request Jun 10, 2021
Merged
lcawl added a commit that referenced this pull request Jun 10, 2021
@lcawl
[DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (#101696) (#…
f84b9d0 
…101972)
lcawl added a commit that referenced this pull request Jun 10, 2021
@lcawl
[DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (#101696) (#…
62fe7ae 
…101973)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 14, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
4b96500 
* master: (68 commits)
  skip flaky suite (elastic#94043)
  skip flaky suite (elastic#102012)
  [esArchive] Persists updates for management/saved_objects/* (elastic#101992)
  skip flaky suite (elastic#101449)
  remove unnecessary hack (elastic#101909)
  [Exploratory View] Use human readable formats (elastic#101520)
  [Expressions] Refactor expression functions to use observables underneath (elastic#100409)
  [esArchives] Persist migrated Kibana archives (elastic#101950)
  [kbnArchiver] fix save to non-existent file (elastic#101974)
  [Enterprise Search] Add owner and description properties to kibana.json (elastic#101957)
  [DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (elastic#101696)
  [Observability] [Cases] Cases in the observability app (elastic#101487)
  [Alerting][Docs] Combine rule creation and management pages (elastic#101498)
  temporarily disable build-buddy
  [Fleet] Fix fleet server collector in case settings are not set (elastic#101752)
  [Event Log] Populated rule.* ECS fields for alert events. (elastic#101132)
  [APM] Fleet support for merging input.config values with other nested properties in the policy input (elastic#101690)
  Add comments to some alerting plugin public API items (elastic#101551)
  [Alerting][Docs] Moving alerting setup to its own page (elastic#101323)
  remove uptime public API, it's not used. (elastic#101799)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravikesarwani ravikesarwani ravikesarwani approved these changes

@jasonrhodes jasonrhodes Awaiting requested review from jasonrhodes

Assignees
No one assigned
Labels
docs Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc bug as to how to edit Monitoring alerts
3 participants
@lcawl @ravikesarwani @rashmivkulkarni